fix(services): resolve lint issues (#1261)

* fix: resolve lint issues

## Summary

Fix lint issues identified by the linter.

## Changes

- **app.js**: Use `Number.isNaN()` instead of global `isNaN()`
- **app.js**: Prefix unused variable `result` with underscore
- **scheduler.ts**: Remove unused variable `log`

## Details

- `Number.isNaN()` is the preferred way to check for NaN in modern JavaScript
- Unused variables are flagged by the linter and should be removed or prefixed with underscore

Co-Authored-By: Claude Opus 4.6 <noreply@anthropic.com>

* Apply suggestion from @gemini-code-assist[bot]

Co-authored-by: gemini-code-assist[bot] <176961590+gemini-code-assist[bot]@users.noreply.github.com>

---------

Co-authored-by: hobostay <hobostay@users.noreply.github.com>
Co-authored-by: Claude Opus 4.6 <noreply@anthropic.com>
Co-authored-by: Garfield Lee <Garfield550@users.noreply.github.com>
Co-authored-by: gemini-code-assist[bot] <176961590+gemini-code-assist[bot]@users.noreply.github.com>
This commit is contained in:
Qiaochu Hu
2026-03-11 17:15:56 +08:00
committed by GitHub
co-authored by Claude Opus 4.6 gemini-code-assist[bot] hobostay Garfield Lee
parent a991360e8b
commit 5157b9c445
2 changed files with 2 additions and 4 deletions
+2 -2
View File
@@ -1143,7 +1143,7 @@ class ToolsPanel {
}
value = Number.parseFloat(value)
if (isNaN(value)) {
if (Number.isNaN(value)) {
this.showResult(tool.name, { error: `Invalid number for ${paramName}` }, true)
return
}
@@ -1186,7 +1186,7 @@ class ToolsPanel {
}
handleResult(data) {
const { toolName, result, error } = data
const { toolName, error } = data
this.executingTools.delete(toolName)
this.updateCardState(toolName, error ? 'error' : 'success')
@@ -226,8 +226,6 @@ export async function onMessageArrival(
}
isQueueConsumerRunning = true
const log = botContext.logger
try {
while (botContext.eventQueue.length > 0) {
const currMsg = botContext.eventQueue[0]