nanakura/moeka-project
1
0
Fork 0
Code Issues Pull Requests 1 Actions 2 Packages Projects Releases Wiki Activity

fix(stage-tamagotchi): include install-electron in scripts to ensure electron (#2392)

Browse Source 
## Description

Let `dev` and `start` scripts run `install-electron` before
`electron-vite`.

Electron 42 removed the `postinstall` script. The `electron` package now
downloads its binary on its `bin` entry's first run. `electron-vite`
reads `node_modules/electron/path.txt` directly, so it never starts that
download. A fresh install therefore fails with:

```
error during start dev server and electron app:
Error: Electron uninstall
    at getElectronPath (...)
    ...
```

`install-electron` runs the same code as the removed `postinstall`
script. It returns immediately when the binary is already present.
This commit is contained in:
Makito
2026-08-29 02:13:45 +09:00
committed by GitHub
parent 48ee12d184
commit 56bcfc793e
2 changed files with 18 additions and 4 deletions
Download Patch File Download Diff File Expand all files Collapse all files
.github/CONTRIBUTING.md
+14
View File
@@ -174,6 +174,20 @@ pnpm dev:tamagotchi
> nr dev:tamagotchi > nr dev:tamagotchi
> ``` > ```
> [!NOTE]
>
> The `dev` and `start` scripts run `install-electron` before `electron-vite`.
>
> Electron 42 removed the `postinstall` script. The `electron` package now downloads its binary
> when you first run its `bin` entry. `electron-vite` reads `node_modules/electron/path.txt`
> directly, so it never starts that download. A fresh install therefore fails with
> `Error: Electron uninstall`.
>
> `install-electron` runs the same code as the removed `postinstall` script. It returns
> immediately when the binary is already present.
>
> Remove this step after `electron-vite` supports the lazy download.
### Stage Web (Browser version for [airi.moeru.ai](https://airi.moeru.ai)) ### Stage Web (Browser version for [airi.moeru.ai](https://airi.moeru.ai))
```shell ```shell
apps/stage-tamagotchi/package.json
+4 -4
View File
@@ -16,10 +16,10 @@
"typecheck": "vue-tsc --noEmit", "typecheck": "vue-tsc --noEmit",
"app:dev": "pnpm run dev", "app:dev": "pnpm run dev",
"app:build": "pnpm run build", "app:build": "pnpm run build",
"start": "electron-vite preview", "start": "install-electron && electron-vite preview",
"start:xwayland": "electron-vite preview -- --ozone-platform=x11", "start:xwayland": "install-electron && electron-vite preview -- --ozone-platform=x11",
"dev": "electron-vite dev", "dev": "install-electron && electron-vite dev",
"dev:xwayland": "electron-vite dev -- --ozone-platform=x11", "dev:xwayland": "install-electron && electron-vite dev -- --ozone-platform=x11",
"build": "electron-vite build", "build": "electron-vite build",
"postinstall": "electron-builder install-app-deps", "postinstall": "electron-builder install-app-deps",
"build:unpack": "pnpm run build && electron-builder --dir", "build:unpack": "pnpm run build && electron-builder --dir",